-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fars_vs_stat plot in results page #5052
base: master
Are you sure you want to change the base?
Conversation
From my point of view this is fine assuming it works and puts the plots in the right place ... Ian may have more to say on the workflow details |
It does need to pass the workflow generation test ... |
Failure is:
|
I guess we should copy what other workflow plots do ? |
@tdent @rahuldhurkunde I'm going to remove the "uselatex=True" line from the new plot here. This is in keeping with every other PyCBC code (bar one, which probably needs this as well). While the plot clearly looks better with latex, it does display fine without latex. ... I'm not particularly happy with this solution (because it means that in most cases we don't use latex where we could ... Although I remind that latex+matplotlib on clusters was always notoriously unstable and led to a lot of failures), but it is what is currently being used throughout the plotting suite. I think some common option to turn latex on, in every plotting code, would be welcome, but that's outside the scope of this PR. I note that one can use a |
@tdent It would be good to confirm you are happy with removing latex before this is merged. I think it will pass the tests now within the next hour. |
Uh, sure, I think I only inherited usetex from Gareth's pretty paper plot. I had no idea it might set off thoughts of globally reconfiguring the search pipeline plotting suite ... |
Failure while building the Docker container
Checks in other recent PRs are instead building with |
I'm not sure what you mean about OSG, that all looks the same to me. I think the error is:
I suspect software.igwn.org has blocked github. |
Incorporating the output of
pycbc_page_fars_vs_stat
plot in the pycbc results page. This plot would be visible in the summary page and under the background triggers page.Standard information about the request
This is a: new feature which adds an additional plot to the summary page.
This change: has appropriate unit tests, follows style guidelines (See e.g. PEP8), has been proposed using the contribution guidelines
Motivation
The far vs stat plots in the summary pages is crucial to validate the ranking of events during a offline run.
Contents
Adds a new job in the
pycbc_make_offline_search_workflow
which is defined in theworkflow/plotting.py
. Config changes in the mini-search to keep the changes consistent with this PR.Links to any issues or associated PRs
The v2.3.10 release PR see (#5044) requires this to be merged first.
Testing performed
I've tested the mini-search workflow after updating the configs, and it runs successfully.