-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for bower package manager #77
Conversation
Do not ignore contents of dist directory as bower depends on it.
@@ -1,2 +1,2 @@ | |||
* | |||
!.gitignore | |||
!*.js |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why'd you add this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ignore all files except javascript. It's pretty much useless to integrate bower support if you have to manually
compile a dependency.
The dist files should not be checked in as we'd have to continue to check them in after every commit - If bower isn't capable of running a make script, then it shouldn't be in the repo, but could be part of the build process instead and distributed as a .tar.gz the dist directory uses * for it's .gitignore as it should also include things like the Changelist, which isn't .js |
Rejecting in favour of someone coming up with an alternative that doesn't involve checking in duplicate code. |
Bower requires a pre-built distribution. However, I don't see why this couldn't be handled here. It only responds to new release tags, so you wouldn't have to build and check in after every commit, unless you're tagging every commit as a new release. You could have stable built distribution file somewhere in the repo and set it as the main file for Bower. |
@filipegiusti Maybe so. Maybe not making your library accessible on what's becoming a widely adopted method of dependency management just to avoid adding 120kb or so to your repo is also stupid. Maybe the fact that Bower is becoming somewhat of a standard is stupid. I tend not to worry about it, since I imagine it'll all sort itself out. |
Someone else pointed out in another issue that you can do: |
@gwatts Yes, being able to use a direct link works fine. Not ideal for automatic semantic version control of dependencies, but it serves. |
@neverfox did you checked why jQuery doesn't commit the build to the repository? Can you understand that the problem is not only the 120kb in the repo? |
Sure, but just about every reason I've heard can be overcome by pushing the dist files to the tag (all Bower cares about) and resetting. No dist in the repo outside of those tags. No merge conflicts etc. |
Can we put a very simple package.json in the repo, so that it can be installed using npm for use with Browserify? It would only need a name, a version (which doesn't have to be the actual version, it only needs the field filled out with something) and a pointer to the Makefile so that it can run the build locally for the user after it installs. Give an OK, and I'll submit a PR. |
The This would fit with the conventions I'm observing in your peers JS libs. Here are some examples with Here is an example where edit: Actually PouchDB builds it after too..... This works in concert with grunt |
Also added latest release files.
Visit http://bower.io for installation instructions.
After you have installed bower, you need to register the package:
bower register jquery.sparkline git://github.com/gwatts/jquery.sparkline.git