Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layout update event is raised before update is finished #19

Closed
SamGeens opened this issue Sep 24, 2023 · 5 comments
Closed

Layout update event is raised before update is finished #19

SamGeens opened this issue Sep 24, 2023 · 5 comments
Assignees
Labels
wontfix This will not be worked on

Comments

@SamGeens
Copy link

Expected Behavior

Layout update event is raised when updating the layout finishes. Like said in the docs:

Every time the layout has finished updating and positions of all grid-items are recalculated

Current Behavior

The layout event is raised multiple times before updating the layout is finished

Failure Information (for bugs)

Layoutupdateevent.mp4

Steps to Reproduce

The behavior can be seen in this codesandbox.

@gwinnem
Copy link
Owner

gwinnem commented Sep 24, 2023

Hi @SamGeens , tnxs for the feedback. Im on a 3 week holiday right now but I will start looking into the issues you have reported the 3rd week of october

@SamGeens
Copy link
Author

SamGeens commented Sep 24, 2023

Enjoy your holiday! I’m looking very much forward to version 1.2.3. In the meantime I’ll explore this library a bit further and post my findings and questions.

@gwinnem
Copy link
Owner

gwinnem commented Sep 24, 2023 via email

@gwinnem gwinnem added the bug Something isn't working label Sep 27, 2023
@gwinnem gwinnem self-assigned this Sep 29, 2023
@gwinnem gwinnem added wontfix This will not be worked on and removed bug Something isn't working labels Oct 7, 2023
@gwinnem
Copy link
Owner

gwinnem commented Oct 7, 2023

Hi Sam, this event is ment to fire every time the layout is recalculated.
I will introduce a new event which fires only when the final layout update is completed.
The above event will fire when a item is being dragged, dropped or resized.

@gwinnem gwinnem closed this as completed Oct 7, 2023
@SamGeens
Copy link
Author

SamGeens commented Oct 7, 2023

I see, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants