Update cidl to Python 3 compatible #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
string type in Python have `str.rstrip()` method: Python 2: https://docs.python.org/2/library/stdtypes.html#str.rstrip Python 3: https://docs.python.org/3/library/stdtypes.html#str.rstrip
In Python 3, map/filter result return with their object, not list:
>>> v = [1, 2, 3, 4, 5]
>>> vf = filter(lambda x: x, v)
>>> vf
<filter object at 0x7fdcef6f0d90>
We can use `list(filter())` or list(map())` to get the result,
and this should be done in `makefile_deps(path)`, otherwise a
`copy.copy(map)` is meaningless:
>>> vfc = copy.copy(vf)
>>> vfc
<filter object at 0x7fdcef6f06a0>
>>> v[0] = 10000
>>> list(vfc)
[10000, 2, 3, 4, 5]
|
This is amazing. I'm stuck in Python's past, so I appreciate updating this. Do you know if the scripts in the |
|
Yes, they need to update too. This includes three problem that needs to be solved:
|
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of this Pull Request (PR)
Update cidl to Python 3 compatible.
Follow up for https://github.com/gwsystems/composite/pull/430/files#r753611216
Build failed when trying to do
make initIntent for your PR
Choose one (Mandatory):
Reviewers (Mandatory):
@gparmer
Code Quality
As part of this pull request, I've considered the following:
Style:
No coding style bound for Python in SG.
Code Craftsmanship:
Testing
Testing with Python 2.7 & 3.9 result: