Shared memory bitmap allocator #443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aligned memory allocation implemented
Evan/lib/shmem
gparmer
approved these changes
Feb 21, 2022
src/components/lib/shm_bm/shm_bm.h
Outdated
|
|
||
| shmptr = entry->shmptr; | ||
| // obj has not been allocated | ||
| if (unlikely(*(SHM_BM_REFC(shmptr, nobj) + objid) == 0)) return 0; |
There was a problem hiding this comment.
I don't think that this check actually has much utility. It is a subtle argument so we should chat about it at some point.
There was a problem hiding this comment.
I thought this would be required since it is possible for a component to take a reference to an unallocated object otherwise. This might not be something we are worried about tho.
gparmer
reviewed
Feb 25, 2022
| @@ -49,6 +49,18 @@ cos_faa(int *var, int value) | |||
| return value; | |||
| } | |||
|
|
|||
| /* Byte sized fetch-and-add implementation on x86. It returns the | |||
There was a problem hiding this comment.
Add a note and/or empty function for this in arm that blows up?
gparmer
approved these changes
Feb 25, 2022
|
Great job! looks really clean. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of this Pull Request (PR)
Client/Server Shared memory library
shm_bm. Tested on x86_64.Intent for your PR
Choose one (Mandatory):
Reviewers (Mandatory):
(Specify @<github.com username(s)> of the reviewers. Ex: @user1, @user2)
Code Quality
As part of this pull request, I've considered the following:
Style:
Code Craftsmanship:
Testing
I've tested the code using the following test programs (provide list here):