Official NIC/DPDK component support to Composite #451

betahxy · 2022-05-02T05:02:24Z

Summary of this Pull Request (PR)

Add description here.

Intent for your PR

Choose one (Mandatory):

This PR is for a code-review and is intended to get feedback, but not to be pulled yet.
This PR is mature, and ready to be integrated into the repo.

Reviewers (Mandatory):

(Specify @<github.com username(s)> of the reviewers. Ex: @user1, @user2)

Code Quality

As part of this pull request, I've considered the following:

Style:

Comments adhere to the Style Guide (SG)
Spacing adhere's to the SG
Naming adhere's to the SG
All other aspects of the SG are adhered to, or exceptions are justified in this pull request
I have run the auto formatter on my code before submitting this PR (see doc/auto_formatter.md for instructions)

Code Craftsmanship:

I've made an attempt to remove all redundant code
I've considered ways in which my changes might impact existing code, and cleaned it up
I've formatted the code in an effort to make it easier to read (proper error handling, function use, etc...)
I've commented appropriately where code is tricky
I agree that there is no "throw-away" code, and that code in this PR is of high quality

Testing

I've tested the code using the following test programs (provide list here):

micro_booter
unit_pingpong
unit_schedtests
...(add others here)

…he glibc problem, will work on it.

- linker script should be ARCH related - make necessary changes so that DPDK can successfully compile drivers

- some libs need this capability to print in Composite without modifying much code

- successfully probed 1000 pmd and read netcard information like mac address

- set stack size to be 4*4k, all_stack_size to be 66560*4 - this is because some applications like DPDK would require a larger stack size, or the stack could be corrupted

merge with upstream

gparmer

Went through the bench/test and lwip. Looks good to go to me! @WenyuanShao ?

I'm approving, but get @WenyuanShao 's opinion, and I suggested some small fixes.

gparmer · 2022-06-15T21:55:39Z

src/components/implementation/tests/bench_dpdk/doc.md

+```shell
+sudo apt install -y python3-scapy netsniff-ng
+```
+`scapy` is a python-based packect manipulation tool. You can use it to generate any king of packets you want. `netsniff-ng` is a network analyzer tool set. We will only use its `trafgen` to generate traffic and `ifpps` to watch the traffic's speed.


king -> kind

Use a spell checker in your editor to help out with this!

gparmer · 2022-06-15T21:58:32Z

src/components/implementation/tests/bench_dpdk/doc.md

+```shell
+sudo trafgen --cpp --out tap0 --conf ./src/components/implementation/tests/bench_dpdk/traffic_template.trafgen --verbose --cpu 1 -b 1000MiB
+```
+4. Start the program


"Start the program" -> "Start the composite networking system"

Given your directions here, I assume it is OK to start composite after you're generating the workload with trafgen. I would have assumed you wanted to start the workload after composite boots up. But if this works, that's great!

gparmer · 2022-06-15T21:59:16Z

src/components/implementation/tests/bench_dpdk/doc.md

+sudo ./cos run bench_dpdk_test enable-nic
+```
+5. Watch the `ifpps` monitor
+Now you will see in the terminal the rx/tx speed of the `tap0` device. Then you can use `Ctrl+C` to stop the `trafgen`. (At this pointed, If the `trafgen` cannot be stoped, you need to start again the dpdk program and then stop it to make sure the `trafgen` is stopped.) Finally, use `Ctrl+C` to stop the `ifpps`.


"The dpdk program" Don't you mean "start again the composite dpdk system"

gparmer · 2022-06-15T22:02:28Z

src/components/implementation/tests/bench_dpdk/doc.md

@@ -0,0 +1,53 @@
+## How to perform this DPDK test?


Given the scripts and config files in this directory, don't these commands need to be run in this directory? If so, say so.

gparmer · 2022-06-15T22:05:34Z

src/components/lib/lwip/cos_adapter/arch/cc.h

+#define PACK_STRUCT_END
+
+#include <llprint.h>
+#define LWIP_PLATFORM_DIAG(x) do { printc x; } while (0);


Is this used, and it compiles? I'm unaware of the printc x syntax, but I'm guessing that you're assuming that x includes (...). If that's the assumption, might be good to state it, and why this might be used.

gparmer · 2022-06-15T22:06:24Z

src/components/lib/lwip/cos_adapter/arch/perf.h

+#ifdef NIL
+#define PERF_START  { \
+                         unsigned long __c1l, __c1h, __c2l, __c2h; \
+                         __asm__(".byte 0x0f, 0x31" : "=a" (__c1l), "=d" (__c1h))


What is all of this? Can we document it? Get rid of it? etc....

gparmer · 2022-06-15T22:07:47Z

src/components/lib/lwip/cos_adapter/lwipopts.h

+
+#define MEMP_NUM_TCP_PCB 512 	/* need a fair amount of these due to timed wait on close  */
+#define MEMP_NUM_TCP_PCB_LISTEN 128
+#define LWIP_ARP 0


This might be useful on the actual hardware. @WenyuanShao will have to figure out if we need this there.

WenyuanShao · 2022-06-15T22:27:34Z

@gparmer no further comments. Looks good to me as well. I'll start thinking about testing it on the hardware we have since you approve the PR. @betahxy, really exciting having DPDK officially in Composite.

betahxy · 2022-06-19T07:19:07Z

@gparmer I've fixed the suggestions above. Thank you so much for the review!

gparmer · 2022-06-20T17:02:31Z

Thanks for the great research on this @betahxy !

WenyuanShao and others added 30 commits January 19, 2022 00:23

wenyuan: make dpdk using the build system of composite. Haven't fix t…

bf06b90

…he glibc problem, will work on it.

wenyuan: delete fix a file which is not useful

bcf2c96

use private DPDK repo first

89fe11b

make dpdk lib work

426db81

ar dpdk libs to libdpdk

a120aee

test simple dpdk function in llbooter

b873502

compiling DPDK with musl libc in composite

c1eaaf5

compile DPDK witt musl in Composite automatically

50c23c0

Merge branch 'loader' into dpdk-dev

b9fbab5

add posix lib into llbooter

70917bd

Merge branch 'loader' into dpdk-dev

820a117

make tls set fs register correctly in x86_64

071882a

improve dpdk Makefile

838e0f3

init tls space when init libc

ae1c995

Merge branch 'main' into dpdk-dev

31565ac

compile DPDK drivers and change linker script

67e6a40

- linker script should be ARCH related - make necessary changes so that DPDK can successfully compile drivers

add DPDK_COMPOSITE macro to DPDK lib

d07d0cd

make rte_eal_init to begin rte_bus_scan

2e571ff

add cos print in lib musl

19367ba

- some libs need this capability to print in Composite without modifying much code

Merge remote-tracking branch 'origin/main' into dpdk-dev

82ff4f7

remove warnings

7956866

add cos_dpdk_adapter

e33593f

make eal init work and probe e1000 pmd

a96fa22

- successfully probed 1000 pmd and read netcard information like mac address

enable receiving packets

86c5287

fix compiling problem of x86_64

ab19128

use a larger stack size in user level

889601e

- set stack size to be 4*4k, all_stack_size to be 66560*4 - this is because some applications like DPDK would require a larger stack size, or the stack could be corrupted

Qemu e1000 NIC rx/tx simple test OK

634fca7

enable libc_init and override defautl __init_tls

74aafde

enable r/w fs gs base register

a8862e4

remove compiling warnings and improve the dpdk build makefile

d85c8a6

betahxy added 10 commits April 30, 2022 23:12

reserve 256MB memory to memmgr

0940bfa

add memmgr_map_phys_to_virt to memmgr interface

5589508

minor bug fixes

1713e27

minor fixes

be7d3dc

clean lib posix

e768f15

add nic interface

f5bfcfc

Merge remote-tracking branch 'upstream/main'

9535cf3

merge with upstream

change dpdk url to GW's repo

db23356

update dpdk submodule

e357580

add init_env dependencies

5b8fa8e

betahxy requested a review from gparmer May 2, 2022 05:09

betahxy added 13 commits May 2, 2022 07:39

minor fix

8b67159

keep posix legacy as its original content

cc8e98c

add lwip submodule

8c34fa5

add lwip submodule

ba66857

Merge branch 'main' of github.com:betahxy/composite

e307303

add lwip submodule and successfully compile it

0950f94

enable avx feature

0868465

test lwip within nic component

f1c74a1

enable lwip debug message

8bd5569

add DPDK bench test and some minor changes

92585ca

change lwip submodule url to gwsystem

c1fb10c

minor fix

e68d887

fix format

ca2f9f2

gparmer approved these changes Jun 15, 2022

View reviewed changes

minor fixes

22d5f9a

gparmer merged commit b42e20c into gwsystems:main Jun 20, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Official NIC/DPDK component support to Composite #451

Official NIC/DPDK component support to Composite #451

betahxy commented May 2, 2022

gparmer left a comment

gparmer Jun 15, 2022

gparmer Jun 15, 2022

gparmer Jun 15, 2022

gparmer Jun 15, 2022

gparmer Jun 15, 2022

gparmer Jun 15, 2022

gparmer Jun 15, 2022

WenyuanShao commented Jun 15, 2022

betahxy commented Jun 19, 2022

gparmer commented Jun 20, 2022

Official NIC/DPDK component support to Composite #451

Official NIC/DPDK component support to Composite #451

Conversation

betahxy commented May 2, 2022

Summary of this Pull Request (PR)

Intent for your PR

Reviewers (Mandatory):

Code Quality

Testing

gparmer left a comment

Choose a reason for hiding this comment

gparmer Jun 15, 2022

Choose a reason for hiding this comment

gparmer Jun 15, 2022

Choose a reason for hiding this comment

gparmer Jun 15, 2022

Choose a reason for hiding this comment

gparmer Jun 15, 2022

Choose a reason for hiding this comment

gparmer Jun 15, 2022

Choose a reason for hiding this comment

gparmer Jun 15, 2022

Choose a reason for hiding this comment

gparmer Jun 15, 2022

Choose a reason for hiding this comment

WenyuanShao commented Jun 15, 2022

betahxy commented Jun 19, 2022

gparmer commented Jun 20, 2022