Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Virtual address space specification, assignment, and booting. #453

Merged
merged 17 commits into from
Jun 26, 2022
Merged

Virtual address space specification, assignment, and booting. #453

merged 17 commits into from
Jun 26, 2022

Conversation

gparmer
Copy link
Collaborator

@gparmer gparmer commented Jun 4, 2022 •
edited
Loading

Summary of this Pull Request (PR)

Adds support for virtual address space knowledge and management into the composer, and feeds that into the booter through the initargs.

  • Adds a specification for address spaces including a hierarchy
  • Adds intelligence into the composer to assign virtual address names to components that share (or split from) a VAS.
  • Adds an initargs description of the address spaces, and integrates them into llbooter.

I'm hoping that this can get rid of the llbooter_vas.c stuff, so I didn't modify that code.

To review, it might be easiest to go through the commits as they are structured in a sequence of successive functionality.

Steps:

  1. Parsing and validation of composition scripts. 6340d95 (and commits leading up to it)
  2. Add an AS representation to the pass structure of the composer for later pass access. 187b371
  3. Order ASes by the parent relationship. ff5cd1c
  4. Assign virtual addresses based on ASes and the parent relation. 8d11d13
  5. Synthesize the initargs based on the ASes and addresses. fe7001a
  6. Use the initargs and the AS specification in the booter. 8a77c31

Intent for your PR

Choose one (Mandatory):

  • This PR is for a code-review and is intended to get feedback, but not to be pulled yet.
  • This PR is mature, and ready to be integrated into the repo.

Reviewers (Mandatory):

@evanstella @WenyuanShao @betahxy

Code Quality

As part of this pull request, I've considered the following:

Style:

  • Comments adhere to the Style Guide (SG)
  • Spacing adhere's to the SG
  • Naming adhere's to the SG
  • All other aspects of the SG are adhered to, or exceptions are justified in this pull request
  • I have run the auto formatter on my code before submitting this PR (see doc/auto_formatter.md for instructions)

Code Craftsmanship:

  • I've made an attempt to remove all redundant code
  • I've considered ways in which my changes might impact existing code, and cleaned it up
  • I've formatted the code in an effort to make it easier to read (proper error handling, function use, etc...)
  • I've commented appropriately where code is tricky
  • I agree that there is no "throw-away" code, and that code in this PR is of high quality

Testing

Some coverage of the tests.

@gparmer
Adding Composer support for address spaces.
94d574e 
Commit 0: Add the parsing and validation logic to the composer
@gparmer
address space parsing tweaks
4c73aa0
@gparmer
AS Composer support: debugged and properly checking the 6 invariants
6340d95
@gparmer
Merge branch 'main' of github.com:gparmer/composite.local into main
e9227a2
@gparmer
Merge branch 'main' into composer_vas
336057e
@gparmer
Step 1 & 2 in adding address space support to the composer: parsing a…
187b371 
…nd validation of composition scripts, and added access to AS representation in the composer's state.

The overall goal is to add full initargs support for address spaces, going all the way back to a specification for address spaces from the composition scripts.

Steps:

1. DONE: parsing and validation of composition scripts.
2. DONE: add an AS representation to the pass structure of the composer for later pass access.
3. Order ASes by the parent relationship.
4. Assign virtual addresses based on ASes and the parent relation.
5. Synthesize the initargs based on the ASes and addresses.
6. Use the initargs and the AS specification in the booter.
@gparmer
Add the pass structures to access ordered address spaces for initiali…
ff5cd1c 
…zation (with containing components, and exclusive AS components)

Steps:
1. DONE: parsing and validation of composition scripts.
2. DONE: add an AS representation to the pass structure of the composer for later pass access.
3. -> DONE: Order ASes by the parent relationship.
4. Assign virtual addresses based on ASes and the parent relation.
5. Synthesize the initargs based on the ASes and addresses.
6. Use the initargs and the AS specification in the booter.
@gparmer
Steps:
3ef7a71 
1. DONE: parsing and validation of composition scripts.
2. DONE: add an AS representation to the pass structure of the composer for later pass access.
3. DONE: Order ASes by the parent relationship.
4. -> DONE: Assign virtual addresses based on ASes and the parent relation.
    This is *not yet integrated into the output*. That's next commit.

5. Synthesize the initargs based on the ASes and addresses.
6. Use the initargs and the AS specification in the booter.
@gparmer
Steps:
8d11d13 
1. DONE: parsing and validation of composition scripts.
2. DONE: add an AS representation to the pass structure of the composer for later pass access.
3. DONE: Order ASes by the parent relationship.
4. DONE: Assign virtual addresses based on ASes and the parent relation.
    -> Now integrated into the output!
5. Synthesize the initargs based on the ASes and addresses.
6. Use the initargs and the AS specification in the booter.
@gparmer
Synthesize the composer's initargs based on the address space speci…
fe7001a 
…fication.

Steps:
1. DONE: parsing and validation of composition scripts.
2. DONE: add an AS representation to the pass structure of the composer for later pass access.
3. DONE: Order ASes by the parent relationship.
4. DONE: Assign virtual addresses based on ASes and the parent relation.
5. -> DONE: Synthesize the initargs based on the ASes and addresses.
6. Use the initargs and the AS specification in the booter.
@gparmer
WARNING: does not build. Transient commit
7915890
@gparmer
WARNING: does not build. Transient commit
052b284
@gparmer
Updated booter to use the VAS specification.
8a77c31 
Steps:
1. DONE: parsing and validation of composition scripts.
2. DONE: add an AS representation to the pass structure of the composer for later pass access.
3. DONE: Order ASes by the parent relationship.
4. DONE: Assign virtual addresses based on ASes and the parent relation.
5. DONE: Synthesize the initargs based on the ASes and addresses.
6. -> DONE: Use the initargs and the AS specification in the booter.

Pending: BUG for split ASes that don't properly maintain non-overlapping ASes.
@gparmer
Fixed last bug, ready to go forward!
d2b231b 
Steps:
1. DONE: parsing and validation of composition scripts.
2. DONE: add an AS representation to the pass structure of the composer for later pass access.
3. DONE: Order ASes by the parent relationship.
4. DONE: Assign virtual addresses based on ASes and the parent relation.
5. DONE: Synthesize the initargs based on the ASes and addresses.
6. DONE: Use the initargs and the AS specification in the booter.
@betahxy
Copy link
Contributor

betahxy commented Jun 12, 2022

Excellent PR! Thanks for the detailed review steps here.

@gparmer gparmer merged commit 0da657c into gwsystems:main Jun 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WenyuanShao WenyuanShao Awaiting requested review from WenyuanShao

@betahxy betahxy Awaiting requested review from betahxy

@evanstella evanstella Awaiting requested review from evanstella

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gparmer @betahxy