Skip to content

Commit

Permalink
Fix error reporting for System.getProperty magic method nodes (#9812)
Browse files Browse the repository at this point in the history
An earlier iteration appeared to add getProperty to GWT.java instead of
using System. In that implementation, the "answers" for rebind seemed
to be reused to hold default expressions, but that also changed before
it was submitted to GWT.

Fixes #9806
  • Loading branch information
niloc132 authored Apr 11, 2023
1 parent 1671fc2 commit 65a0674
Showing 1 changed file with 4 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -731,15 +731,13 @@ public boolean visit(JPermutationDependentValue x, Context ctx) {
print(".class)");
} else {
assert x.isProperty();
print("GWT.getProperty(");
print("System.getProperty(");
print("\"");
print(x.getRequestedValue());
print("\"");
if (x.getResultValues().get(0) != null) {
print(",");
print("\"");
print(x.getResultValues().get(0));
print("\"");
if (x.getDefaultValueExpression() != null) {
print(", ");
accept(x.getDefaultValueExpression());
}
print(")");
}
Expand Down

0 comments on commit 65a0674

Please sign in to comment.