Did some minor refactoring.

gzachos · Sep 30, 2019 · 7fc984a · 7fc984a
1 parent ece49d2
commit 7fc984a
Showing 1 changed file with 5 additions and 9 deletions.
diff --git a/mars/tools/StackVisualizer.java b/mars/tools/StackVisualizer.java
@@ -161,8 +161,7 @@ public Component getTableCellRendererComponent(JTable table, Object value, boole
 				else if (row > spDataRowIndex) {
 					color = GRAY;
 				}
-				else {
-					if (row % 2 == 0)
+				else if (row % 2 == 0) {
 						color = LIGHT_GRAY;
 				}
 				c.setBackground(new Color(color));
@@ -514,23 +513,19 @@ private void processRegisterAccessNotice(RegisterAccessNotice notice) {
 	}
 
 	private void processStackMemoryUpdate(MemoryAccessNotice notice) {
-		String regName, frameName;
+		String regName = "", frameName = "";
 
 		if (notice.getAccessType() == AccessNotice.READ)
 			return;
 
 		if (regNameToBeStoredInStack != null) {
 			regName = regNameToBeStoredInStack;
 			regNameToBeStoredInStack = null;
-		} else {
-			regName = "";
 		}
 
 		if (frameNameToBeCreated != null) {
 			frameName = frameNameToBeCreated;
 			frameNameToBeCreated = null;
-		} else {
-			frameName = "";
 		}
 
 		if (debug) {
@@ -823,8 +818,9 @@ protected void reset() {
 	}
 
 	private void updateSpDataRowColIndex() {
-		spDataRowIndex = getTableRowIndex(getSpValue());
-		spDataColumnIndex = getTableColumnIndex(getSpValue());
+		int spValue = getSpValue();
+		spDataRowIndex = getTableRowIndex(spValue);
+		spDataColumnIndex = getTableColumnIndex(spValue);
 	}
 
 	private void resetStoredRegAndFrameNameColumns(int startRow, int endRow) {