Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ZarrArray): add store get options passthrough #146

Merged
merged 2 commits into from
Oct 1, 2023

Conversation

az0uz
Copy link
Contributor

@az0uz az0uz commented Jul 19, 2023

  • Allows store get options to be pass through when using ZarrArray.get (previously only available with ZarrArray.getRaw)
  • improve typescript to have store store options type inferred from constructor Store type.

This will allow new features like passing an AbortController from the ZarrArray.get to the Store.getItem if the Store supports it, which would be welcomed for frontend user loading large data arrays where the user input change while loading.

Copy link
Collaborator

@manzt manzt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. Thanks for the contribution.

@az0uz
Copy link
Contributor Author

az0uz commented Oct 22, 2023

This is great. Thanks for the contribution.

@manzt You might want to also merge #145 for this to work correctly, so the AbortError is thrown as expected

@az0uz az0uz deleted the az0uz/store_get_options_passthrough branch December 30, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants