Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve flexsearch feedback #517

Merged
merged 6 commits into from
Oct 16, 2021

Conversation

schnerring
Copy link
Contributor

Fixes #514

@schnerring
Copy link
Contributor Author

Ah, found a small bug. Don't merge yet!

@schnerring
Copy link
Contributor Author

Okay, looks good. Is i18n a concern regarding the message?

@h-enk
Copy link
Member

h-enk commented Oct 15, 2021

Nice! Deploy preview: https://deploy-preview-517--doks.netlify.app/

Snag_575f87e

Is i18n a concern regarding the message?

Not really (for now). I guess it's quite a hassle / it would require an additional dependency like e.g. i18next?

@schnerring
Copy link
Contributor Author

Yeah, out of scope for this PR for sure. I think it would be possible to build different flexsearch indexes for each language and include them in the corresponding pages.

@schnerring
Copy link
Contributor Author

But for now it's good as is, so if you're ready, go ahead and merge it 👍

Copy link
Member

@h-enk h-enk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@h-enk h-enk merged commit f96f977 into thuliteio:master Oct 16, 2021
adhadse pushed a commit to adhadse/doks that referenced this pull request Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No feedback on no search results
2 participants