Improve flexsearch feedback #517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, found a small bug. Don't merge yet! |
|
Okay, looks good. Is i18n a concern regarding the message? |
|
Nice! Deploy preview: https://deploy-preview-517--doks.netlify.app/
Not really (for now). I guess it's quite a hassle / it would require an additional dependency like e.g. i18next? |
|
Yeah, out of scope for this PR for sure. I think it would be possible to build different flexsearch indexes for each language and include them in the corresponding pages. |
|
But for now it's good as is, so if you're ready, go ahead and merge it 👍 |
adhadse
pushed a commit
to adhadse/doks
that referenced
this pull request
Sep 17, 2022
…eedback Improve flexsearch feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #514