Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update activation failure warning #1

Closed
wants to merge 2 commits into from

Conversation

maresb
Copy link

@maresb maresb commented Jul 28, 2023

@maresb maresb requested a review from h-vetinari as a code owner July 28, 2023 16:10
@h-vetinari
Copy link
Owner

Thanks. I'll fold this into the next PR to main, resp. any backports to the maintenance branches that arise, though I modified it slightly (linebreak before "Unless"):

--- a/recipe/activate.sh
+++ b/recipe/activate.sh
@@ -65,9 +65,9 @@ for _la_target in "$_la_orig_install_dir/"*.py; do
     mkdir -p "$_la_symlink_dir" || true
     # this check also creates the symlink; if it fails, we enter the if-branch.
     if ! ln -sf "$_la_target" "$_la_symlink"; then
-        echo -n "${BASH_SOURCE[0]} ERROR: Failed to create symlink from "
-        echo -n "'$_la_target' to '$_la_symlink'!"
-        echo
+        echo -n "${BASH_SOURCE[0]} WARNING: Failed to create symlink from "
+        echo "'$_la_target' to '$_la_symlink'!"
+        echo "Unless you plan to use the GDB debugger with libarrow, this warning can be safely ignored."
         continue
     fi
 done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants