watermarkImage must be in lowerCamelCase #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
watermarkImage instead watermarkimage
{"message":"Error while processing the image: Unsupported operation name: watermarkimage","code":1}
https://github.com/h2non/imaginary/blob/cc53838d71e38f2d7163e8ae0280f466ce4f9998/image.go#L29
|
Thanks for your contribution! Since all endpoints, even ones with multiple words, are in lowercase. The fix should be to change the route instead. So if you revert your change, and instead apply this one, I can merge it in! diff --git image.go image.go
index 736a321..345595d 100644
--- image.go
+++ image.go
@@ -26,7 +26,7 @@ var OperationsMap = map[string]Operation{
"zoom": Zoom,
"convert": Convert,
"watermark": Watermark,
- "watermarkImage": WatermarkImage,
+ "watermarkimage": WatermarkImage,
"blur": GaussianBlur,
"smartcrop": SmartCrop,
"fit": Fit, |
|
@Dynom |
|
@bscheshirwork Agreed. I need to think about what the best approach is. We could introduce a temporary alias with a deprecation warning or again bump a minor version (1.2.x) or take it as is and hope it wont break for anyone. |
😹 |
j-keck
pushed a commit
to artidis/imaginary
that referenced
this pull request
Aug 11, 2022
watermarkImage instead watermarkimage
{"message":"Error while processing the image: Unsupported operation name: watermarkimage","code":1}
https://github.com/h2non/imaginary/blob/cc53838d71e38f2d7163e8ae0280f466ce4f9998/image.go#L29
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
watermarkImage instead watermarkimage
{"message":"Error while processing the image: Unsupported operation name: watermarkimage","code":1}
imaginary/image.go
Line 29 in cc53838