Ignore urllib3 test failure on 3.6

(WIP) Fix urllib3 patching

urllib3 matchers do not work at the moment

Enable pook in test case

pook/interceptors/urllib3.py

@@ -12,7 +12,7 @@
 
 PATCHES = (
     'requests.packages.urllib3.connectionpool.HTTPConnectionPool.urlopen',
-    'urllib3.connectionpool.HTTPConnectionPool.urlopen'
+    'urllib3.connectionpool.HTTPConnectionPool.urlopen',
 )
 
 RESPONSE_CLASS = 'HTTPResponse'

tests/unit/conftest.py

@@ -0,0 +1,16 @@
+import pytest
+
+import pook
+
+
+@pytest.fixture
+def pook_on():
+    """
+    Safely toggle pook on before a test, then off afterwards.
+
+    @pook.on does not mix with pytest marks. This works around
+    that limitation.
+    """
+    pook.on()
+    yield
+    pook.off()

tests/unit/interceptors/aiohttp_test.py

@@ -19,14 +19,6 @@
 ).read_bytes()
 
 
-@pytest.fixture
-def pook_on():
-    # Cannot use `@pook.on` with pytest marks
-    pook.on()
-    yield
-    pook.off()
-
-
 def _pook_url():
     return pook.head(URL).reply(200).mock
 

tests/unit/interceptors/urllib3_test.py

@@ -2,6 +2,8 @@
 
 import urllib3
 import pook
+import pytest
+import sys
 
 from pathlib import Path
 
@@ -84,9 +86,16 @@ def test_binary_body_chunked():
     assert list(r.read_chunked()) == [binary_file]
 
 
-def test_post_with_headers():
-    # this test failed with urllib3 v2.0.3
-    pook.post('https://example.org').reply(200)
+@pytest.mark.xfail(
+    condition=sys.version_info < (3, 7),
+    reason=(
+        "urllib3 converts https to http with "
+        "port 443 and fails on header parsing"
+    )
+)
+def test_post_with_headers(pook_on):
+    mock = pook.post('https://example.com').header('k', 'v').reply(200).mock
     http = urllib3.PoolManager(headers={'k': 'v'})
-    resp = http.request('POST', 'https://example.org')
+    resp = http.request('POST', 'https://example.com', headers={'k': 'v'})
     assert resp.status == 200
+    assert len(mock.matches) == 1

tox.ini

@@ -11,5 +11,6 @@ commands =
 	pytest
 
 [testenv:py36]
+requires = virtualenv<20.22.0
 commands =
     pytest -k 'not aiohttp'