Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Frame.copy() does not copy key columns #1443

Closed
st-pasha opened this issue Nov 23, 2018 · 0 comments · Fixed by #1444
Closed

Frame.copy() does not copy key columns #1443

st-pasha opened this issue Nov 23, 2018 · 0 comments · Fixed by #1444
Assignees
@st-pasha
Labels
bug Any bugs / errors in datatable; however for severe bugs use [segfault] label
Milestone
Release 0.8.0

Comments

@st-pasha
Copy link
Contributor

This fails:

>>> import datatable as dt
>>> DT = dt.Frame(A=[1,2,3], B=['f', 'wer', 'd'])
>>> DT.key = "A"
>>> DT2 = DT.copy()
>>> assert DT2.key == DT.key
@st-pasha st-pasha self-assigned this Nov 23, 2018
@st-pasha st-pasha added the bug Any bugs / errors in datatable; however for severe bugs use [segfault] label label Nov 23, 2018
@st-pasha st-pasha mentioned this issue Nov 23, 2018
Merged
st-pasha added a commit that referenced this issue Nov 23, 2018
@st-pasha
Pickling of Frames (#1444)
b62faff 
- Frame now supports pickle interface;
- when copying a Frame, its key property is no longer lost;
- `Frame.save()` can now also be called without any arguments -- it will save the Frame into memory in Jay format, and return the bytes object containing the Frame's data;
- `dt.open()` can now accept a bytes argument -- same as returned from `Frame.save()`. 

Closes #1442 
Closes #1443
@st-pasha st-pasha added this to the Release 0.8.0 milestone Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@st-pasha st-pasha

Labels
bug Any bugs / errors in datatable; however for severe bugs use [segfault] label
Projects
None yet
Milestone
Release 0.8.0
Development

Successfully merging a pull request may close this issue.

Pickling of Frames h2oai/datatable
1 participant
@st-pasha