Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Segfault when attempting to modify nrows of a 0-row frame #1527

Closed
nkalonia1 opened this issue Jan 10, 2019 · 0 comments · Fixed by #1529
Closed

Segfault when attempting to modify nrows of a 0-row frame #1527

nkalonia1 opened this issue Jan 10, 2019 · 0 comments · Fixed by #1529
Assignees
@st-pasha
Labels
segfault Severe bugs that lead to crashes / seg.faults / process termination
Milestone
Release 0.8.0

Comments

@nkalonia1
Copy link
Contributor 

>>> x = dt.Frame({"a": []})

>>> x
      a
---  --

[0 rows x 1 column]


>>> x.nrows
0

>>> x.nrows = 3

>>> x
Segmentation fault
@nkalonia1 nkalonia1 added the segfault Severe bugs that lead to crashes / seg.faults / process termination label Jan 10, 2019
@st-pasha st-pasha added this to the Release 0.8.0 milestone Jan 10, 2019
@st-pasha st-pasha mentioned this issue Jan 10, 2019
Merged
st-pasha added a commit that referenced this issue Jan 10, 2019
@st-pasha
Remove internal py::DataWindow class (#1529)
0fbe4b8 
- Internal method `frame.internal.window(row0, row1, col0, col1)` is removed. Same result can be achieved via `frame[row0:row1, col0:col1].to_list()`;
- Removed class `py::DataWindow` which used to handle the `.window()` call. This class has been around since the very early days of datatable, and grew useless over time;
- The `DT[i, j]` call is able to handle different row indices without problems, resolving issue #1527.

Closes #1527
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@st-pasha st-pasha

Labels
segfault Severe bugs that lead to crashes / seg.faults / process termination
Projects
None yet
Milestone
Release 0.8.0
Development

Successfully merging a pull request may close this issue.

Remove internal py::DataWindow class h2oai/datatable
2 participants
@st-pasha @nkalonia1