Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dt.prod() calculates sum instead of a product for the grouped columns #3390

Closed
oleksiyskononenko opened this issue Nov 29, 2022 · 2 comments · Fixed by #3396
Closed

dt.prod() calculates sum instead of a product for the grouped columns #3390

oleksiyskononenko opened this issue Nov 29, 2022 · 2 comments · Fixed by #3396
Assignees
@samukweku
Labels
bug Any bugs / errors in datatable; however for severe bugs use [segfault] label
Milestone
Release 1.1.0

Comments

@oleksiyskononenko
Copy link
Contributor 

>>> from datatable import dt, f
>>> DT = dt.Frame([1, 1])
>>> DT[:, dt.prod(f.C0)]
   |    C0
   | int64
-- + -----
 0 |     1
[1 row x 1 column]
>>> DT[:, dt.prod(f.C0), by(f.C0)]
   |   C0     C1
   | int8  int64
-- + ----  -----
 0 |    1      2
[1 row x 2 columns]

Note, the product on the grouped column should still be 1, i.e. the correct result for the last example is

   |   C0     C1
   | int8  int64
-- + ----  -----
 0 |    1      1
[1 row x 2 columns]
@oleksiyskononenko oleksiyskononenko added the bug Any bugs / errors in datatable; however for severe bugs use [segfault] label label Nov 29, 2022
@oleksiyskononenko oleksiyskononenko added this to the Release 1.1.0 milestone Nov 29, 2022
@samukweku samukweku mentioned this issue Nov 29, 2022
Merged
oleksiyskononenko pushed a commit that referenced this issue Dec 12, 2022
@samukweku
Refactor sum() and prod() reducers to use FExpr (#3388)
d803ba8 
WIP for #2562 
Closes #3390
@oleksiyskononenko
Copy link
Contributor Author

@samukweku I still wonder why this bug was not caught by our tests, even though you've got a test for prod() on the grouped columns. Do you have time to look at this test and adjust it if necessary?

@samukweku
Copy link
Contributor

@oleksiyskononenko sure I'll have a look

@samukweku samukweku reopened this Dec 12, 2022
@samukweku samukweku mentioned this issue Dec 12, 2022
Merged
oleksiyskononenko pushed a commit that referenced this issue Dec 14, 2022
@samukweku
Add dt.prod() test for a grouped column, by() docs adjustment (#3396
81d1f9b 
)

- the fix for #3390 has been already pushed as a part of #3388, here we merely add a corresponding test;
- as of #2472, `f[:]` excludes the groupby columns, in this PR we make the corresponding adjustments to the docs. 

Closes #3390
samukweku added a commit that referenced this issue Jan 3, 2023
@samukweku
Refactor sum() and prod() reducers to use FExpr (#3388)
dbad9c5 
WIP for #2562
Closes #3390
samukweku added a commit that referenced this issue Jan 3, 2023
@samukweku
Add dt.prod() test for a grouped column, by() docs adjustment (#3396
997bd88 
)

- the fix for #3390 has been already pushed as a part of #3388, here we merely add a corresponding test;
- as of #2472, `f[:]` excludes the groupby columns, in this PR we make the corresponding adjustments to the docs. 

Closes #3390
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samukweku samukweku

Labels
bug Any bugs / errors in datatable; however for severe bugs use [segfault] label
Projects
None yet
Milestone
Release 1.1.0
Development

Successfully merging a pull request may close this issue.

Add dt.prod() test for a grouped column, by() docs adjustment h2oai/datatable
2 participants
@samukweku @oleksiyskononenko