Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dt.median() when used on a groupby context for void columns #3412

Merged
merged 1 commit into from
Jan 19, 2023
Merged

Fix dt.median() when used on a groupby context for void columns #3412

merged 1 commit into from
Jan 19, 2023

Conversation

oleksiyskononenko
Copy link
Contributor

@oleksiyskononenko oleksiyskononenko commented Jan 19, 2023 •
edited
Loading

In this PR we fix dt.median()

  • when called on void columns within a groupby context that has more than one group;
  • for frames that are grouped by a void column;
  • tests that tested dt.mean() instead;
  • return type in documentation.

Closes #3411

@oleksiyskononenko oleksiyskononenko added bug Any bugs / errors in datatable; however for severe bugs use [segfault] label documentation FIX Fix for an issue labels Jan 19, 2023
@oleksiyskononenko oleksiyskononenko added this to the Release 1.1.0 milestone Jan 19, 2023
@oleksiyskononenko oleksiyskononenko self-assigned this Jan 19, 2023
@oleksiyskononenko oleksiyskononenko mentioned this pull request Jan 19, 2023
Merged
@oleksiyskononenko oleksiyskononenko merged commit 5abae44 into main Jan 19, 2023
@oleksiyskononenko oleksiyskononenko deleted the ok/gb-median branch January 19, 2023 18:29
@oleksiyskononenko oleksiyskononenko mentioned this pull request May 2, 2023
Merged
oleksiyskononenko added a commit that referenced this pull request May 2, 2023
@oleksiyskononenko
Fortify fix #3412 for dt.median() (#3461)
394daaf 
Closes #3460.
samukweku pushed a commit that referenced this pull request May 2, 2023
@oleksiyskononenko @samukweku
Fortify fix #3412 for dt.median() (#3461)
9359b59 
Closes #3460.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samukweku samukweku samukweku approved these changes

Assignees

@oleksiyskononenko oleksiyskononenko

Labels
bug Any bugs / errors in datatable; however for severe bugs use [segfault] label documentation FIX Fix for an issue
Projects
None yet
Milestone
Release 1.1.0
Development

Successfully merging this pull request may close these issues.

dt.median() errors when used on void columns in a groupby context
2 participants
@oleksiyskononenko @samukweku