-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Max Length rework #741
Max Length rework #741
Conversation
…into psi/maxlength
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @psinger. Great changes!
Some suggestions in the code.
I would also suggest to add a small note in the Readme for recent breaking changes, as depending on the parameters, the new behavior could be different, but should be better in general and resemble the chat_template
from transformers
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the quick changes, looks good to me!
This PR adresses several related points:
max_length_prompt
andmax_length_answer
and only keepsmax_length
. It will always use that setting to truncate the left side of the whole input.max_length
.position_ids
to the forward method of the backbone.