Make chat optional from UI/client #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alse case since chat requires going through disk jsons and not useful/required for client calls.
|
checkbox in expert can switch chat mode to simple non-chat mode:
Both chat and non-chat tracks are entirely independent, and one can switch to the other in the UI without losing the other case:
For client code, it should always take the chat=False track, because the gradio chat goes through tile system with json files to do its work, which isn't available remotely. Also too hard to maintain that track due to how inputs/outputs processed for chatbot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And simplify client to just chat=False case since chat requires going through disk jsons and not useful/required for client calls.