Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add directed peer address parameter to advertising start. #507

Merged
merged 1 commit into from
Apr 6, 2023

Conversation

h2zero
Copy link
Owner

@h2zero h2zero commented Feb 20, 2023

Adds a parameter to NimBLEAdvertising::start to take the peer address for use with directed advertising.

Fixes #501

Adds a parameter to NimBLEAdvertising::start to take the peer address for use with directed advertising.
@h2zero
Copy link
Owner Author

h2zero commented Mar 26, 2023

@ViktorRindom Have you been able to test this?

@ViktorRindom
Copy link

ViktorRindom commented Mar 27, 2023

Sorry but no. My implementation is using undirected connections now because I have to accept an entire whitelist of devices. I dont have time to make a example to test it but thank you for the quick fix.

@h2zero h2zero merged commit fbafcf7 into release/1.4 Apr 6, 2023
@h2zero h2zero deleted the bugfix-directed-adv branch April 6, 2023 18:04
h2zero added a commit that referenced this pull request Apr 6, 2023
Adds a parameter to NimBLEAdvertising::start to take the peer address for use with directed advertising.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

peer_addr = null when doing directed advertising
2 participants