Set manufacturer data directly instead of converting from string #529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
overloaded setManufacturerData to allow vector of uint8_t to be added to manufacturer data
overloaded setManufacturerData to allow vector of uint8_t to be added directly
|
Thank you for this, I will merge it soon. |
|
@eighty2fifty1 I made some minor changes if you'd like to comment/test before merge? |
h2zero
pushed a commit
that referenced
this pull request
May 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For my purposes, I found it useful to be able to directly input integers into manufacturer data, so I created this PR to allow me to do so. It works perfectly on my application (ESP32 DEVKIT V1).