Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update example to initialize pAdvertising after NimBLEDevice::init() #545

Merged
merged 1 commit into from
May 19, 2023

Conversation

ankgt
Copy link
Contributor

@ankgt ankgt commented May 16, 2023

Initializing the pAdvertising variable from NimBLEDevice::init() when defining it globally results in the device name getting truncated. Corrected to initialize it after NimBLEDevice::init().

Initializing the pAdvertising variable from NimBLEDevice::init while defining it as a globally results in the name getting truncated.
@ankgt
Copy link
Contributor Author

ankgt commented May 16, 2023

My first ever PR on GitHub! Please let me know if I have done something incorrectly. Thanks.

@h2zero h2zero changed the title Initialize pAdvertising after NimBLEDevice::init() Update example to initialize pAdvertising after NimBLEDevice::init() May 18, 2023
@h2zero
Copy link
Owner

h2zero commented May 18, 2023

Congrats on the first PR and thank you 😄

@h2zero h2zero merged commit bb8b670 into h2zero:release/1.4 May 19, 2023
h2zero pushed a commit that referenced this pull request May 28, 2023
Initializing the pAdvertising variable from NimBLEDevice::init while defining it as a globally results in the name getting truncated.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants