Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BREAKING] Refactor NimBLEAdvertised device. #700

Merged
merged 1 commit into from
Jul 18, 2024

Commits on Jul 18, 2024

  1. [BREAKING] Refactor NimBLEAdvertised device.

    * Construct the device with the parameters from the advertisement in the initialization list.
    * Removed no longer needed methods; setAddress, setAdvType, setRSSI, setSetId, setPrimaryPhy, setSecondaryPhy, setPeriodicInterval.
    * Removed `hasRSSI()` method, the RSSI is always reported so this is redundant.
    * Replace setPayload with new method; `update` which will update the device info when new advertisement data is received.
    * getPayload now returns `const std::vector<uint8_t>` instead of a pointer to internal memory.
    * Added `begin` and `end` read-only iterators for convienience and use in range loops.
    * Timestamp removed, if needed then the app should track the time in the callback.
    * Consolidate some functions to use getPayloadByType.
    * Add optional index parameter to getPayloadByType.
    * Change payload indexing to use 0 as the first item.
    * Code cleanup and apply const correctness.
    h2zero committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    821d510 View commit details
    Browse the repository at this point in the history