Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Client): Provide filter argument in discoverAttributes #885

Closed
wants to merge 1 commit into from
Closed

fix(Client): Provide filter argument in discoverAttributes #885

wants to merge 1 commit into from

Conversation

thekurtovic
Copy link
Contributor

Resolves #884

@thekurtovic thekurtovic force-pushed the bugfix branch 2 times, most recently from 86e6dd7 to eb3c2e5 Compare February 4, 2025 05:08
@h2zero
Copy link
Owner

h2zero commented Feb 4, 2025

Thanks! Curious as to the need for a full revert instead of just providing a filter with a NULL UUID?

@thekurtovic thekurtovic changed the title fix(RemoteChar): Revert NimBLEDescriptorFilter fix(Client): Provide filter argument in discoverAttributes Feb 6, 2025
@thekurtovic
Copy link
Contributor Author

taken from an existing PR. maybe better if you handle it

@thekurtovic thekurtovic closed this Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Weird crash with discoverAttributes() in 2.2.1
2 participants
@thekurtovic @h2zero