Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing NimBLEUtils and NimBLEConnInfo includes to NimBLEDevice.h #268

Merged
merged 1 commit into from
Dec 15, 2024
Merged

Add missing NimBLEUtils and NimBLEConnInfo includes to NimBLEDevice.h #268

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,10 @@ All notable changes to this project will be documented in this file.

## Fixed
- `NimBLEHIDDevice::getOutputReport` will now return the correct characteristic.
- Compile error when central is disabled.
- Compile error when central is disabled, class `NimBLEServer` has no member named `m_pClient`.

## Changed
- Added missing includes for `NimBLEConnInfo` and `NimBLEUtils` to `NimBLEDevice.h`.

## [2.0.0] 2024-12-14

Expand Down
11 changes: 3 additions & 8 deletions src/NimBLEDescriptor.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,17 +21,12 @@
#include "nimconfig.h"
#if defined(CONFIG_BT_ENABLED) && defined(CONFIG_BT_NIMBLE_ROLE_PERIPHERAL)

class NimBLEDescriptor;
class NimBLEDescriptorCallbacks;

# include "NimBLELocalValueAttribute.h"
# include "NimBLECharacteristic.h"
# include "NimBLEUUID.h"
# include "NimBLEAttValue.h"
# include "NimBLEConnInfo.h"

# include <string>

class NimBLECharacteristic;
class NimBLEDescriptorCallbacks;

/**
* @brief A model of a BLE descriptor.
*/
Expand Down
6 changes: 6 additions & 0 deletions src/NimBLEDevice.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,5 +282,11 @@ class NimBLEDevice {
# endif
# endif

# if defined(CONFIG_BT_NIMBLE_ROLE_CENTRAL) || defined(CONFIG_BT_NIMBLE_ROLE_PERIPHERAL)
# include "NimBLEConnInfo.h"
# endif

# include "NimBLEUtils.h"

#endif // CONFIG_BT_ENABLED
#endif // NIMBLE_CPP_DEVICE_H_
Loading