Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade glam to 0.22, bump minimum to 0.21 #12

Merged
merged 1 commit into from
Oct 24, 2022
Merged

Upgrade glam to 0.22, bump minimum to 0.21 #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,10 @@ documentation = "https://docs.rs/dolly"
keywords = ["gamedev", "camera", "3d"]
categories = ["game-development"]
readme = "crates-io.md"
rust-version = "1.58.1"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copied this from glam, but I don't recall any of the needed const machinery being introduced in that version. Regardless, dolly should probably check+enforce some MSRV in its CI (perhaps other code requires higher Rust versions already).


[dependencies]
glam = ">=0.15, <=0.21"
glam = ">=0.21, <=0.22"

[dev-dependencies]
macroquad = "0.3"
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

[![Crates.io](https://img.shields.io/crates/v/dolly.svg)](https://crates.io/crates/dolly)
[![Docs](https://docs.rs/dolly/badge.svg)](https://docs.rs/dolly)
[![Rust 1.58.1](https://img.shields.io/badge/Rust-1.58.1-fc8d62?logo=rust)](https://github.com/rust-lang/rust/blob/master/RELEASES.md#version-1581-2022-01-19)

Combine simple building blocks to create smooth cameras: first-person, chase, orbit, look-at, you name it!

Expand Down
6 changes: 1 addition & 5 deletions src/handedness.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,7 @@ use glam::Vec3;

pub trait Handedness: Clone + Copy + Debug + 'static {
const FORWARD_Z_SIGN: f32;
// `glam::const_vec3!` is deprecated since 0.21 and to be replaced with
// `glam::Vec3::new(0.0, 0.0, Self::FORWARD_Z_SIGN)`. Consider replacing
// it when bumping glam's minimum version to 0.21.
#[allow(deprecated)]
const FORWARD: Vec3 = glam::const_vec3!([0.0, 0.0, Self::FORWARD_Z_SIGN]);
const FORWARD: Vec3 = glam::vec3(0.0, 0.0, Self::FORWARD_Z_SIGN);

fn right_from_up_and_forward(up: Vec3, forward: Vec3) -> Vec3;
fn up_from_right_and_forward(right: Vec3, forward: Vec3) -> Vec3;
Expand Down