Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GitHub Actions configuration #13

Merged
merged 1 commit into from
Nov 7, 2022
Merged

Add GitHub Actions configuration #13

merged 1 commit into from
Nov 7, 2022

Conversation

MarijnS95
Copy link
Contributor

This is a minimal setup that checks code formatting, clippy lints (also a check), documentation and specifically broken intradoc links and directives, and the current MSRV of 1.58.1.

@MarijnS95
Add GitHub Actions configuration
e5f36b0 
This is a minimal setup that checks code formatting, clippy lints (also
a `check`), documentation and specifically broken intradoc links and
directives, and the current MSRV of 1.58.1.
@MarijnS95 MarijnS95 mentioned this pull request Oct 25, 2022
Merged
@MarijnS95
Copy link
Contributor Author

MarijnS95 commented Oct 25, 2022 •
edited
Loading

GitHub only parses on: triggers from the "Default" branch, so this'll only start running inside PR contexts after merging (but it does already run on my fork: https://github.com/MarijnS95/dolly/actions/runs/3320849938).

@MarijnS95
Copy link
Contributor Author

Ping @h3r2tic :)

@h3r2tic
Copy link
Owner

h3r2tic commented Nov 7, 2022

Oops, sorry for the lag! This is very nice, thanks a lot of setting it up ❤️😍🙏

LGTM, let's get it in 😀

@h3r2tic h3r2tic merged commit efaf628 into h3r2tic:main Nov 7, 2022
@MarijnS95 MarijnS95 deleted the github-actions branch November 7, 2022 18:20
@MarijnS95
Copy link
Contributor Author

No worries, I was just checking through all my (stale) branches in forks and noticed this was still open, hope you still find it useful after it starts complaining on newer Rust releases every 6 weeks 😬

@h3r2tic
Copy link
Owner

h3r2tic commented Nov 7, 2022

How about right away! :D #14

@MarijnS95
Copy link
Contributor Author

I swear the CI was green when submitting this, looks like a nonbreaking semver change in bytemuck bumped MSRV.

@h3r2tic
Copy link
Owner

h3r2tic commented Nov 7, 2022

Hehe, yeah, no worries. And yeah, the offending change was just two days ago.

@MarijnS95
Copy link
Contributor Author

MarijnS95 commented Nov 7, 2022 •
edited
Loading

More of my repos are hit by it... 🤷

OTOH I'm fine bumping MSRV beyond a Rust release >6 months ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarijnS95 @h3r2tic