Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples: set rescaler parameters, use setAverageFrameRate() for MKV #32

Merged
merged 1 commit into from
Nov 27, 2017

Conversation

rkfg
Copy link
Contributor

@rkfg rkfg commented Nov 27, 2017

Killing two birds with one stone, let's show an example of rescale and setting average FPS, also fixes the code so it actually works.

@h4tr3d h4tr3d merged commit a2be4c7 into h4tr3d:master Nov 27, 2017
@h4tr3d
Copy link
Owner

h4tr3d commented Nov 27, 2017

@rkfg, so, what will be happens if we will setup avg_frame_rate always?

@rkfg
Copy link
Contributor Author

rkfg commented Nov 27, 2017

I guess nothing bad would happen, but I can't possibly imagine all use cases. FFmpeg copies these values separately when it copies streams and uses r_frame_rate mostly to get the rate from the input stream and avg_frame_rate to set it to the output stream. It's confusing, yes. I think unless someone with better understanding of these internals clear the situation up, we should stick to the original plan, i.e. just have to separate methods for both fields.

@h4tr3d
Copy link
Owner

h4tr3d commented Nov 27, 2017

Ok, I agree. Currently I have no time to dig it and I have no active projects that uses FFmpeg/avcpp.

Also, thanks for good observation: input streams - r_frame_rate, output streams - avg_frame_rate.

@h4tr3d
Copy link
Owner

h4tr3d commented Nov 27, 2017

In any case, thanks for contributions :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants