-
Notifications
You must be signed in to change notification settings - Fork 12.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved CDN and analytics #1659
Conversation
Improved CDN fallbacks and analytics snippet
@@ -12,7 +12,11 @@ | |||
|
|||
<link rel="stylesheet" href="css/normalize.css"> | |||
<link rel="stylesheet" href="css/main.css"> | |||
<script src="js/vendor/modernizr-2.8.3.min.js"></script> | |||
<script src="//cdnjs.cloudflare.com/ajax/libs/modernizr/2.8.3/modernizr.min.js"></script> |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
removed modernizr cdn
i updated the file to have only jquery fallback |
well, if no medernizr, it can be anywhere
this way no need to fear from using b
FIX can't do function inside function
This would make the jQuery fallback async, we don't want that. It might result in jQuery not being defined before other stuff gets executed. |
i think the jquery fallback is async either way (also in current version) |
@BLooperZ |
Added global function for CDN fallbacks,
Modernizr is served with CDN as well (the cdn itsef can be changed)
Made use of it on the analytics snippet
(don't mind the "x-ua-compatible" yet, still on open issue: #1656)
pros:
with modernizr fallback: 465 against 525
without modernizr: 410 against 433
(counted with the spaces in " || " removed)
cons: