Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Access-Control-Allow-Origin pointing to an origin should include Vary: Origin #192

Closed
Malvoz opened this issue May 27, 2019 · 1 comment · Fixed by #271
Closed

Access-Control-Allow-Origin pointing to an origin should include Vary: Origin #192

Malvoz opened this issue May 27, 2019 · 1 comment · Fixed by #271
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@Malvoz
Copy link
Contributor

Malvoz commented May 27, 2019

When Access-Control-Allow-Origin points to a URL rather than *, then Vary: Origin should be sent along with the response.

Sources:

All of the CORS configs use * in the examples. But if anything, there could potentially be a note of this in requests.conf? Or something better than just a note?

@LeoColomb LeoColomb changed the title [Enhancement] Access-Control-Allow-Origin pointing to an origin should include Vary: Origin Access-Control-Allow-Origin pointing to an origin should include Vary: Origin May 27, 2019
@LeoColomb LeoColomb added the enhancement New feature or request label May 27, 2019
@LeoColomb
Copy link
Member

A note seems to be a good start. 👍

Maybe the note can be attached to a commented out directive:

# (1)
# Header append Vary Origin

@LeoColomb LeoColomb added good first issue Good for newcomers help wanted Extra attention is needed labels Jul 31, 2019
LeoColomb added a commit that referenced this issue Jun 14, 2021
@LeoColomb LeoColomb linked a pull request Jun 14, 2021 that will close this issue
5 tasks
LeoColomb added a commit that referenced this issue Jun 14, 2021
LeoColomb added a commit that referenced this issue Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants