Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a notice for directory index with pre-compressed content #311

Merged
merged 4 commits into from May 28, 2022
Merged

Add a notice for directory index with pre-compressed content #311

merged 4 commits into from May 28, 2022

Conversation

ghost
Copy link

@ghost ghost commented May 27, 2022

Added comment about serving Gzip and brotli pre-compressed resources only and how to do that, with one DirectoryIndex directive example for that case.

Also, moved Apache Gzip article link to the bottom to match writing style of pre-compressed_content_brotli.conf file.

vatonbero added 2 commits May 27, 2022 21:44
Added comment about serving Gzip pre-compressed resources only and how to do that, with one example of `DirectoryIndex` directive for that case.
Also, moved Apache Gzip article link to the bottom to match writing style of `pre-compressed_content_brotli.conf` file.
Added comment about serving brotli pre-compressed resources only and how to do that, with one example of `DirectoryIndex` directive for that case.
Copy link
Member

@LeoColomb LeoColomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this PR @vatonbero! 👍
I made little adjustments to keep this as simple as possible and align to comment formatting.

@LeoColomb LeoColomb linked an issue May 28, 2022 that may be closed by this pull request
@LeoColomb LeoColomb changed the title DirectoryIndex comment, with example, about serving pre-compressed content as index of the directory Add a notice for directory index with pre-compressed content May 28, 2022
@LeoColomb LeoColomb merged commit 231eba8 into h5bp:main May 28, 2022
@ghost
Copy link
Author

ghost commented May 28, 2022

Thanks a lot for this PR @vatonbero! +1 I made little adjustments to keep this as simple as possible and align to comment formatting.

Awesome, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DirectoryIndex comment if pre-compressed content is enabled
1 participant