Make compatible with Firefox WebExtensions #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The WebExtensions manifest.json specifies that the author key is a string, not an object. Split out author.name and author.url into author and homepage_url strings. The email key is discarded as the spec does not support it.
Firefox WebExtension addons do not allow assignment to innerHTML with unsanitised content. Use DOMPurify[1] to sanitise the outline HTML passed from the content process. [1]: https://github.com/cure53/DOMPurify
WebExtensions submitted to AMO must have all files in the root of the submitted zip file, not in a containing directory.
|
That typo must have slipped in after testing, but before committing. :/ A verified-working Firefox XPI, generated using AMO and the grunt-built zip file, is temporarily available at https://repo.celti.name/html5_outliner-0.8.13-an%2Bfx.xpi for ease of testing. |
|
Thanks! I'll try to look into this soon! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firefox 57 uses WebExtensions with 95% compatibility with Chrome. This PR covers that last 5%.
While commit 116983e makes the generated zip file compatible with AMO, this PR does not make any changes to Travis to sign an XPI or actually submit the extension for Firefox.