fix(mount): Handle multiple calls to componentDidMount #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brdlyptrs
commented
Jun 27, 2023
zoryana94
previously approved these changes
Jun 28, 2023
|
Re-tested it in multiple apps |
zoryana94
approved these changes
Nov 6, 2024
damian-rodriguez-imi
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #189
Reason
It seems that componentDidMount is called multiple times when using functions like
useNavigate, resulting in hCaptcha's render function to be called multiple times as well (see screenshot). A single hCaptcha element is only allowed to render once in an element, which results in the error outlined in the linked issue.Note: This seems to be an issue with React.StrictMode as well, see StackOverflow
Result
Add check to validate hCaptcha has already been created to prevent calling
hCaptcha.renderagain if a component already exists.Evidence