feat: Add the hasBackdrop property #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@emilianodevborn thanks! mind updating the README? |
zoryana94
changed the title
zoryana94
reviewed
Sep 19, 2023
zoryana94
reviewed
Sep 21, 2023
zoryana94
reviewed
Sep 21, 2023
package.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "@hcaptcha/react-native-hcaptcha", | |||
| "version": "1.5.1", | |||
| "version": "1.5.2", | |||
There was a problem hiding this comment.
@emilianodevborn, please also update the version to 1.6.0 as it's technically the new feature
There was a problem hiding this comment.
@zoryana94 Done!
e271828-
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In the case of size=invisible the SDK still shows the modal backDrop
Solution
Add a new hasBackdrop property to handle the modal backDrop behaviour