-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add username who made the commit - Issue #85 #86
Conversation
update adorner to start layout right-aligned to each commit
Thanks! I'll try and look at this soon. |
One of the goals of SeeGit is to be a teaching tool during a live talk. In that scenario, the speaker is the only one making commits so the name is redundant. My preference would be to add a setting to show the name and default it to be off. We already have other settings. If you make the setting sticky, it should accomplish what you want here. |
…nder the settings view
That makes sense. I added an option in the settings for showing the Commit Author. I did have one bit of code in the OnToggleSettings method that I'm not thrilled with. When the commit author is displayed, it changes the width of each CommitVertex. When this happens, a call to Relayout needs to be made. Ideally, the fact that the Graph property of the ViewModel changed should be enough information for the control to know that it needs to lay itself out again. I'm not familiar enough with the RepositoryGraphLayout control to do this though. |
@@ -9,6 +9,7 @@ namespace SeeGit | |||
/// </summary> | |||
internal class CommitTemplatedAdorner : Adorner | |||
{ | |||
private FrameworkElement _adornedElement; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nit, but since this isn't settable, it should be readonly
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just committed the change to use readonly.
Maybe the |
Implementation for adding the username who made the commit