[sqitch_pg] Cannot build

[smacfarlane]

I'm getting the following error when building sqitch_pg

Configuring DBD-Pg-3.7.4
Running Makefile.PL
Path to pg_config?
No POSTGRES_HOME defined, cannot find automatically
Configuring DBD::Pg 3.7.4
-> N/A
-> FAIL Configure failed for DBD-Pg-3.7.4. See /root/.cpanm/work/1528295890.3713/build.log for details.

Habitat version:

hab 0.56.0/20180530234342
habitat-docker-registry.bintray.io/studio   0.56.0              46004381881b

[smacfarlane]

I attempted to set POSTGRES_HOME and it was able detect the libraries and headers, but DBD::Pg was still unable to determine the version of Postgresql.

Tracing the source, I see DBD::Pg uses App::Info to determine the installed Postgresql version, which isn't provided by the postgresql-client package.

Next, I added postgresql to the pkg_build_deps and was able to successfully build, but the generated dynamic libraries had runpaths referencing postgresql and not postgresql-client, which is not what we want.

I think by including pg_config in the postgresql-client package, we can get the desired behavior. This appears to be what ArchLinux does with its postgresql-libs package.

[irvingpop]

thanks for the good notes @smacfarlane - looks like we could remove this line to restore pg_config: https://github.com/habitat-sh/core-plans/blob/master/postgresql-client/plan.sh#L27

[rsertelon]

@smacfarlane did it build fine on builder? I've opened #1519 a while back, maybe it works fine now?

[smacfarlane]

@rsertelon It did! I'm going to close out #1519 for now, if the issue appears again we can re-open it.