[postgresql-client] Fix sqitch_pg and dbdpg building against postgresql-client, they depend on pg_config. #1625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request! Here is what will happen next:
Thank you for contributing! |
irvingpop
force-pushed
the
irving/fix_sqitch_pg
branch
from
4d53654 to
3956425
Compare
irvingpop
changed the title
joshbrand
approved these changes
Jun 27, 2018
smacfarlane
suggested changes
Jun 27, 2018
CODEOWNERS
Outdated
| @@ -102,6 +102,7 @@ lessmsi @mwrock | |||
| visual-cpp-build-tools-2015 @mwrock | |||
| visual-cpp-redist-2013 @mwrock | |||
| wix @mwrock | |||
| postgresql-client @joshbrand @irvingpop | |||
There was a problem hiding this comment.
Could you move this to the Community Plans section?
There was a problem hiding this comment.
no problem @smacfarlane
…nd on pg_config. also add this plan to CODEOWNERS Signed-off-by: Irving Popovetsky <irving@chef.io>
irvingpop
force-pushed
the
irving/fix_sqitch_pg
branch
from
98fe07a to
3ffb04e
Compare
…ry::Tiny is found. Also fix CODEOWNERS Signed-off-by: Irving Popovetsky <irving@chef.io>
irvingpop
force-pushed
the
irving/fix_sqitch_pg
branch
from
3ffb04e to
b39784a
Compare
smacfarlane
approved these changes
Jun 27, 2018
|
I'm going to take @joshbrand approval of this PR as agreement to be added to CODEOWNERS for postgresql-client. We can open another PR if you wish to be removed. |
This was referenced Jul 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
postgresql-clientpackage stripped out thepg_configbinary, which impacts Sqitch's ability to determine information about the version and location of Postgres it is talking to. This PR corrects that, while also improving the sqitch plan to push PERL5LIB to the runtime_env.also adds this plan to CODEOWNERS
Fixes #1572
Signed-off-by: Irving Popovetsky irving@chef.io