Update postgresql9X-client plans to include pg_config #1632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Scott Macfarlane <smacfarlane@chef.io>
|
Thanks for the pull request! Here is what will happen next:
Thank you for contributing! |
|
Er...was the goal to add pg_config or remove it? |
|
Yeah, this one is a hair confusing. The items in that list are considered "server" binaries and removed from the resulting postgresqlXX-client package. By removing it from the list, we include pg_config in the package. pg_config is necessary for some software that builds against the postgresql libraries, which should be using the -client and not server packages. Ex: #1625 |
|
@nellshamrell it's a little confusing, those listed binaries are removed ( https://github.com/habitat-sh/core-plans/blob/master/postgresql-client/plan.sh#L48-L61 ) as they would only be needed on the server 😸 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1596 and aligns the 9X-client packages with the postgresql-client package.
Signed-off-by: Scott Macfarlane smacfarlane@chef.io