helm release fixes #249
Merged
helm release fixes #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The example RBAC file wasn't updated after adding a custom CRD versions support - it allowed the operator to manage only statefulsets as at the point of the change the operator handled only them; deployments were dropped. Right now the operator can manage both deployments and statefulsets depending on the custom version specified in the Habitat resource manifest. The manifest file for the helm chart was also out-of-sync with the changes in the operator - the rules allowed operator only to manage deployments. Signed-off-by: Krzesimir Nowak <krzesimir@kinvolk.io>
asymmetric
suggested changes
Apr 23, 2018
helm/habitat-operator/Chart.yaml
Outdated
| - name: Krzesimir Nowak | ||
| email: krzesimir@kinvolk.io | ||
| - name: Iago López Galeiras | ||
| email: iago@okinvolk.io |
There was a problem hiding this comment.
Ah, so that's where this o went. ;)
There was a problem hiding this comment.
Or should that be iago@ocisly.io?
|
One more case in which the manifests under I really think we should find a better way here. |
True. Not to mention that we also have RBAC rules in the Edit: Errr, I meant in |
|
Filed #250 for keeping RBAC rules in sync. |
Signed-off-by: Krzesimir Nowak <krzesimir@kinvolk.io>
krnowak
force-pushed
the
krnowak/helm-release-fixes
branch
from
9cb4cf7
to
7779df1
Compare
|
Updated. |
asymmetric
approved these changes
Apr 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the RBAC rules. Update the helm package maintainers list.