Compare Resource Versions on update #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iaguis
reviewed
May 9, 2018
| if !ok { | ||
| level.Error(hc.logger).Log("msg", "Failed to type assert StatefulSet", "obj", newObj) | ||
| return | ||
| } | ||
|
|
||
| h, err := hc.getHabitatFromLabeledResource(sts) | ||
| if oldSTS.ResourceVersion == newSTS.ResourceVersion { | ||
| level.Debug(hc.logger).Log("msg", "Update ignored as it didn't change Pod resource version", "pod", newSTS.Name) |
asymmetric
force-pushed
the
asymmetric/res-ver
branch
from
751617c
to
338abdd
Compare
added 2 commits
May 14, 2018 13:46
The ResourceVersion field can be used to know if an item has changed. If there is nothing to do for an item that hasn't changed, the item can be skipped. See point 9 of the [guidelines](https://github.com/kubernetes/community/blob/b8d4a1b389bd105d23ca496b1c67febe1e2efdf2/contributors/devel/controllers.md). Signed-off-by: Lorenzo Manacorda <lorenzo@kinvolk.io>
For clarity. Signed-off-by: Lorenzo Manacorda <lorenzo@kinvolk.io>
asymmetric
force-pushed
the
asymmetric/res-ver
branch
from
338abdd
to
67a6586
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accoriding to the controller design doc:
We don't need to do anything when the
Habitathasn't changed so we can safely skip requeueing the object.