controller/v1beta2: Warn users when owned resources are changed. #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kosyfrances
force-pushed
the
kosy/warn-users-resources
branch
from
89c4c91
to
082ba5d
Compare
asymmetric
suggested changes
May 14, 2018
pkg/controller/v1beta2/controller.go
Outdated
| messageCMFailed = "Failed creating ConfigMap" | ||
| messagePeerIPAdded = "Added peer IP to ConfigMap" | ||
| messagePeerIPUpdated = "Updated peer IP in ConfigMap" | ||
| messagePeerIPUpdatedWarn = "Readonly configuration updated. Update will be reverted" |
There was a problem hiding this comment.
The variable name should be more generic, as this warning applies to multiple situtations. Something like messageReadOnlyResourceChanged.
pkg/controller/v1beta2/controller.go
Outdated
| @@ -488,6 +489,8 @@ func (hc *HabitatController) handleConfigMap(h *habv1beta1.Habitat) error { | |||
|
|
|||
| level.Info(hc.logger).Log("msg", messagePeerIPUpdated, "name", cm.Name, "ip", leaderIP) | |||
| hc.recorder.Event(h, apiv1.EventTypeNormal, cmUpdated, messagePeerIPUpdated) | |||
| level.Warn(hc.logger).Log("msg", messagePeerIPUpdatedWarn, "name", cm.Name, "ip", leaderIP) | |||
There was a problem hiding this comment.
Here, it's the operator who has just updated the CM, so it's not one of the situations we should warn users about.
kosyfrances
force-pushed
the
kosy/warn-users-resources
branch
from
082ba5d
to
fa087f8
Compare
pkg/controller/v1beta2/controller.go
Outdated
| messageCMFailed = "Failed creating ConfigMap" | ||
| messagePeerIPAdded = "Added peer IP to ConfigMap" | ||
| messagePeerIPUpdated = "Updated peer IP in ConfigMap" | ||
| messageReadOnlyResourceChanged = "Readonly configuration updated. Update will be reverted" |
There was a problem hiding this comment.
Nitpick: Maybe add the new variable at the end of the block instead of in the middle, unless it fits in some kind of an order?
kosyfrances
force-pushed
the
kosy/warn-users-resources
branch
2 times, most recently
from
4aaf3b1
to
286ecf6
Compare
kosyfrances
commented
May 17, 2018
| hc.handleCM(newObj) | ||
| } | ||
|
|
||
| func (hc *HabitatController) handleCMDelete(obj interface{}) { | ||
| level.Warn(hc.logger).Log("msg", messageReadOnlyResourceChanged) |
There was a problem hiding this comment.
I'm not sure if some kind of tag should be added to this message, just like that of the others. For example: level.Warn(hc.logger).Log("msg", messageReadOnlyResourceChanged, "name", pod.Name)
|
Please take a look again :) |
We should warn users when habitat's own resources are manually modified, because the operator will override these changes. Signed-off-by: Kosy Anyanwu <kosy@kinvolk.io>
kosyfrances
force-pushed
the
kosy/warn-users-resources
branch
from
286ecf6
to
a21ec6b
Compare
|
I'd say "no" for this PR at the moment. It produces a lot of output from the operator, even when I'm not doing anything after just creating a standalone example: It is way too verbose. The verbosity maybe could be cut down if we somehow detected that nothing really happened, so nothing is going to change. When writing this message I got another bunch of lines: |
|
@krnowak do you think we should close this PR and educate the users instead? |
|
Yes. I'm not sure what we should do to educate users, maybe add something to the design doc. |
|
The design doc already states that those resources are readonly. Maybe at some point we will get this functionality in kubernetes itself, which we can use. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #252
We should warn users when habitat's own resources are manually modified,
because the operator will override these changes.