-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove quotes around pkg_name and pkg_origin #281
base: main
Are you sure you want to change the base?
Conversation
pkg_version=$(cat "$PLAN_CONTEXT/../VERSION") | ||
pkg_name=habitat-operator | ||
pkg_origin=habitat | ||
pkg_version="v$(cat "$PLAN_CONTEXT/../VERSION")" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hope the quotes here are fine 😂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes those quotes are fine 🤣
Before merging this, we need to revise our release process I think. This is because I think the builder will build a new docker image on every merged PR with a tag being a version of the last stable release. And what I would like to have is:
My builder-fu is too weak to be able to say what builder is actually currently doing. |
I think probably what we want to do is have the version file track the next version. So the change would be: bump the VERSION file whenever we cut a release. |
@elliott-davis that's also a good idea, but I agree with @krnowak that it would be nice if we could have unreleased master be tagged as Is builder equipped to do this at the moment? i.e. it could check if the merge commit has a git tag, and decide which Docker tag to build based on that. |
Closes: #279
Closes: #280
Signed-off-by: Elliott Davis elliott@excellent.io