Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove quotes around pkg_name and pkg_origin #281

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

elliott-davis
Copy link

@elliott-davis elliott-davis commented May 15, 2018

  • add v back to version string

Closes: #279
Closes: #280

Signed-off-by: Elliott Davis elliott@excellent.io

* add v back to version string

Closes: #279
Closes: #280

Signed-off-by: Elliott Davis <elliott@excellent.io>
pkg_version=$(cat "$PLAN_CONTEXT/../VERSION")
pkg_name=habitat-operator
pkg_origin=habitat
pkg_version="v$(cat "$PLAN_CONTEXT/../VERSION")"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope the quotes here are fine 😂

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes those quotes are fine 🤣

@krnowak
Copy link
Contributor

krnowak commented May 16, 2018

Before merging this, we need to revise our release process I think. This is because I think the builder will build a new docker image on every merged PR with a tag being a version of the last stable release. And what I would like to have is:

  • when we do a release (say, version 0.7.0), builder builds a docker image and pushes it to docker hub as habitat/habitat-operator:v0.7.0 and habitat/habitat-operator:latest.
  • when we just merge a PR, builder builder builds a docker image and pushes it to docker hub as habitat/habitat-operator:latest only.

My builder-fu is too weak to be able to say what builder is actually currently doing.

@elliott-davis
Copy link
Author

I think probably what we want to do is have the version file track the next version. So the change would be: bump the VERSION file whenever we cut a release.

@asymmetric
Copy link
Contributor

@elliott-davis that's also a good idea, but I agree with @krnowak that it would be nice if we could have unreleased master be tagged as latest, and git tags be tagged with vx.y.z.

Is builder equipped to do this at the moment? i.e. it could check if the merge commit has a git tag, and decide which Docker tag to build based on that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants