Enable test for persistent storage #303
Conversation
kosyfrances
force-pushed
the
kosy/test-persistent-storage
branch
4 times, most recently
from
d947a03
to
6305e52
Compare
|
Needs a rebase. |
We no longer run tests using minikube in a VM on the CI infrastructure but with GCP Signed-off-by: Kosy Anyanwu <kosy@kinvolk.io>
kosyfrances
force-pushed
the
kosy/test-persistent-storage
branch
from
6305e52
to
4cea43c
Compare
| @@ -255,6 +252,13 @@ func TestPersistentStorage(t *testing.T) { | |||
| } | |||
| })(persisted.Name) | |||
|
|
|||
| // Delete the ephemeral resource created | |||
There was a problem hiding this comment.
Should we also do the same for persistent one?
There was a problem hiding this comment.
Well, other tests do not use it so I skipped it instead. The whole cluster still gets deleted at the end of the test anyway.
|
@krnowak I am not sure right now, let me think about it for a bit. |
kosyfrances
force-pushed
the
kosy/test-persistent-storage
branch
3 times, most recently
from
5ad23ae
to
4cea43c
Compare
|
@krnowak The test actually waits for the persisted pod to be in a running state here https://github.com/kinvolk/habitat-operator/blob/4cea43c6323f59495c811705d3070a5b6c423d5a/test/e2e/v1beta1/operator_test.go#L262 |
|
Oh, I overlooked that. In that case, LFAD. |
We no longer run tests using minikube in a VM on the CI infrastructure
but with GCP
Fixes #292
Depends on #302