Add document for CI setup with GCP #310
Conversation
doc/ci-gcp-setup.md
Outdated
|
|
||
| * Open the [Service accounts](https://console.developers.google.com/iam-admin/serviceaccounts) page. If prompted, select a project. | ||
| * Click `Create service account`. | ||
| * In the `Create service account` window, type a name for the service account, and select `Furnish a new private key`. If you want to grant [G Suite domain-wide authority](https://developers.google.com/identity/protocols/OAuth2ServiceAccount#delegatingauthority) to the service account, also select `Enable G Suite Domain-wide Delegation`. Then click `Save`. |
There was a problem hiding this comment.
How is this "G Suite domain-wide authority" thing relevant to the setup?
There was a problem hiding this comment.
Not sure. Lorenzo did the major part of the initial setup so I am not sure if he used it or not.
There was a problem hiding this comment.
I doubt we need it anyway
doc/ci-gcp-setup.md
Outdated
| * Click `Create service account`. | ||
| * In the `Create service account` window, type a name for the service account, and select `Furnish a new private key`. If you want to grant [G Suite domain-wide authority](https://developers.google.com/identity/protocols/OAuth2ServiceAccount#delegatingauthority) to the service account, also select `Enable G Suite Domain-wide Delegation`. Then click `Save`. | ||
|
|
||
| Your new public/private key pair is generated and downloaded to your machine; it serves as the only copy of this key. `You are responsible for storing it securely`. |
There was a problem hiding this comment.
I think that instead of using backticks to accent the message about storing the keys securely, you could use double asterisks **this will be bold** -> this will be bold.
|
@krnowak it is ready for another review 🎉 |
|
Hmph, forgot about this PR. LFAD. |
|
I'd like @indradhanush to have a look at it, just in case. |
doc/ci-gcp-setup.md
Outdated
| ``` | ||
|
|
||
| ### No Auth Provider found for name "gcp" | ||
| k8s.io/client-go/plugin/pkg/client/auth/gcp package was added fix the error |
There was a problem hiding this comment.
Nitpick: `k8s.io/client-go/plugin/pkg/client/auth/gcp` vs k8s.io/client-go/plugin/pkg/client/auth/gcp
There was a problem hiding this comment.
Nitpick: "was added to fix the error:"
Signed-off-by: Kosy Anyanwu <kosy@kinvolk.io>
kosyfrances
force-pushed
the
kosy/ci-docs
branch
from
a729c8f
to
8eb0829
Compare
|
@krnowak @indradhanush ready for another review 😎 |
No description provided.