Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

makefile: add clean-test as a pre-requisite to e2e #326

Closed
wants to merge 1 commit into from

Conversation

surajssd
Copy link
Contributor

@surajssd surajssd commented Aug 2, 2018

If there is a dirty environment which had e2e run before, if you try
re-running e2e the tests fail.

This commit adds makes clean-test as a pre-requisite to e2e tests.

If there is a dirty environment which had e2e run before, if you try
re-running e2e the tests fail.

This commit adds makes clean-test as a pre-requisite to e2e tests.

Signed-off-by: Suraj Deshmukh <suraj@kinvolk.io>
@krnowak
Copy link
Contributor

krnowak commented Aug 7, 2018

I was about to ask if doing kubectl delete on a nonexistent resource make kubectl's exit status to be nonzero, but then I thought that if the tests passed then this change would be safe (as I don't have a k8s cluster at my hand for now to check it myself). But I see that there are no tests at all and that is because the branch you want to merge comes from your fork at your account. And there, CI was not set up at all. Could you create a PR from a branch that comes from our kinvolk clone and then close this one? With that done, we will get tests running.

@surajssd surajssd closed this Aug 7, 2018
@surajssd surajssd deleted the fix-makefile branch August 7, 2018 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants