Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[controller]: move StatefulSet from v1beta1 to v1 #334

Merged

Conversation

surajssd
Copy link
Contributor

@surajssd surajssd commented Aug 13, 2018

The StatefulSets we generate are of version v1beta1, and
StatefulSets are stable in 1.9.

This commit adds support to generate StatefulSet of
version v1 and not v1beta1.

Fixes #342

Copy link
Contributor

@krnowak krnowak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LFAD in general, but that change needs to happen after we move away from k8s 1.8 and start supporting k8s 1.11.

@surajssd surajssd force-pushed the surajssd/move-statefulset-v1 branch from 2f5d792 to af786dc Compare August 16, 2018 07:52
The StatefulSets we generate are of version `v1beta1`, and
StatefulSets are stable in 1.9.

This commit adds support to generate `StatefulSet` of
version `v1` and not `v1beta1`.

Signed-off-by: Suraj Deshmukh <suraj@kinvolk.io>
@surajssd surajssd force-pushed the surajssd/move-statefulset-v1 branch from af786dc to 2d12a5a Compare August 20, 2018 11:47
@surajssd surajssd changed the title [StatefulSet version]: move from v1beta1 to v1 [controller]: move StatefulSet from v1beta1 to v1 Aug 20, 2018
@krnowak
Copy link
Contributor

krnowak commented Aug 20, 2018

LFAD.

@krnowak krnowak merged commit 23a60a1 into habitat-sh:master Aug 20, 2018
@krnowak krnowak deleted the surajssd/move-statefulset-v1 branch August 20, 2018 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants