Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to mount /files directory from a secret #351

Merged
merged 4 commits into from
Jan 15, 2019
Merged

Add ability to mount /files directory from a secret #351

merged 4 commits into from
Jan 15, 2019

Conversation

jamesc
Copy link

@jamesc jamesc commented Sep 5, 2018

This adds the ability to mount the /files directory of a habitat service via a secret much like is done for config. What is different is that we add all the files that are part of the secret.

This is useful for services that e.g. load certificates via hab file upload right now but want to do it via a k8s primitive.

Signed-off-by: James Casey james@chef.io

@HT154
Copy link

HT154 commented Sep 7, 2018

I think this is better handled by implementing arbitrary volumes (+volumeMounts, see #345). If the operator supported configuring these in Habitat objects and piping them through to the underlying StatefulSet, it wouldn't be necessary for create bespoke implementations for every feature like this.

@jamesc
Copy link
Author

jamesc commented Sep 7, 2018

@HT154 I actually have a branch for the generic case too (https://github.com/jamesc/habitat-operator/tree/jc/generic-volume-mount) that I put together. I went the more limited way as it fitted in with the current model better (similar to the configSecretName and ringSecretName parameters).

I agree there is a bunch of additional options that we need to have in the operator longer term (nodeSelector is the biggest problem for me right now). What I'm challenged by right now is a clean abstraction for adding them into the operator yaml without exposing the underlying primitives like Stateful Set/Pod/... to the end user like we do now.

@jamesc jamesc changed the title Add ability to mount /files directory from a secret. Add ability to mount /files directory from a secret. [DO NOT MERGE] Sep 7, 2018
@jamesc jamesc changed the title Add ability to mount /files directory from a secret. [DO NOT MERGE] Add ability to mount /files directory from a secret Sep 7, 2018
@eeyun eeyun merged commit ddfe20c into habitat-sh:master Jan 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants