Fix array access regression in template rendering #4620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `handlebars` crate introduced a change to how it accesses array
members in version 0.29.0 which is incompatible with Habitat's current
template syntax.
Where Habitat would use something like `{{members[0]}}` to access a
specific array member, `handlebars` now expects `{{members.[0]}}`.
This syntax actually mirrors the original JavaScript implementation,
as well as the syntax of other tools like `jq`. Since using 0.29.0 or
higher of `handlebars` would break any Habitat templates that use
direct array access, we need to lock to version 0.28.3, the last prior
version that works for us.
Future work will need to be done to either use an alternative template
engine, or evolve our templating syntax to use the new syntax.
Thanks to @krnowak for discovering this regression.
Fixes #4615
Signed-off-by: Christopher Maier <cmaier@chef.io>
|
Thanks for the pull request! Here is what will happen next:
Thank you for contributing! |
reset
approved these changes
Feb 15, 2018
|
|
|
@thesentinels approve |
|
🤘 I am testing your branch against master before merging it. We do this to ensure that the master branch is never failing tests. |
|
Late 👍 here, but yep.
|
|
|
Travis CI has
|
💖 Travis CI reports this PR passed. It always makes me feel nice when humans approve of one anothers work. I'm merging this PR now. I just want you and the contributor to answer me one question:
|
christophermaier
added
Focus:Supervisor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent versions of
handlebarschange array index access syntax, breaking that feature in Habitat templates. This pins to the last known-good version ofhandlebars.Read commits for further details.
Fixes #4615